4
100%
master: 100%

Ran 19 Feb 2020 10:30PM CUT

Files 2

Run time 0s

Badge

Embed ▾

Committed 19 Feb 2020 10:29PM CUT coverage: 100.0%. Remained the same

Job # 56.4

Build Type

Pull #24

travis-ci

Committed by

web-flow

Commit Message

Add return_interval option to valid_hotp

There is a flaw in the `valid_hotp` logic introduced in https://github.com/yuce/pot/pull/15 that prevents it from being effectively used: because it returns a raw `boolean`, there is no way to know *which* interval matched: the next one, the 1000th one, or somewhere in between? In order to effectively implement a proper HOTP scheme, you need to track the interval number of the last valid HOTP to prevent its reuse, OR the reuse of a HOTP from any previous interval.

For backwards compatibility, I have retained the default `boolean()` response, but if the `return_interval` option is set, the interval will be returned when a hotp is valid, like `{true, interval()}`.

Pull Request Pull Request #24: Add return_interval option to valid_hotp

Run Details

140 of 140 relevant lines covered (100.0%)

1800.01 hits per line

Source Files on job 56.4

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line
100.0		src/pot_base32.erl	201 + 163	88 + 69	88 + 82	0 - 13	1995.0 + 1994
100.0		src/pot.erl	207 + 201	52 + 48	52 + 49	0 - 1	1469.0 + 1468

100.0
src/

yuce / pot / 56 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 56.4

yuce / pot / 56 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 56.4

yuce / pot / 56 / 4
100%
master: 100%

README BADGES
x