2
91%
master: 91%

Ran 15 Feb 2020 05:32PM UTC

Files 6

Run time 0s

Badge

Embed ▾

Committed 15 Feb 2020 05:24PM UTC coverage: 91.833% (-0.01%) from 91.847%

Job # 220.2

Build Type

push

travis-ci

Committed by

xolox

Commit Message

Try to fix #59 by simplifying approach (removing #47)

To be honest I'm not sure why I merged #47 without critically thinking
through how it would actually work, because I spotted several mistakes
now, reevaluating how it was supposed to work:

- logging.getLogRecordFactory() is documented to "return a callable
  which is used to create a LogRecord" so conceptually "two levels of
  calls" are required for proper usage, however coloredlogs only
  performed "one level of calls" as opposed to two.

- Regardless of the above, the relevant code in coloredlogs is intended
  to make lightweight copies of existing LogRecord objects, not really
  construct new ones, so in retrospect logging.getLogRecordFactory()
  seems like the wrong tool for the job.

- I don't know why I didn't write the "lightweight instance copy" code
  to just copy the __class__ from the original LogRecord instance to
  begin with, but this now seems to me to be the more reasonable
  approach (that should have been used from the beginning).

- I believe this new approach will be more compatible with custom log
  record factories based on the fact that it simply doesn't interact
  with them in any meaningful way 😇.

Run Details

551 of 600 relevant lines covered (91.83%)

0.92 hits per line

xolox / python-coloredlogs / 220 / 2
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 220.2

xolox / python-coloredlogs / 220 / 2 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 220.2

xolox / python-coloredlogs / 220 / 2
91%
master: 91%

README BADGES
x