PHPCSStandards / PHPCSUtils / 291 / 29

DEFAULT BRANCH: develop

LAST BUILD BRANCH: stable

Ran 11 Feb 2020 03:47PM UTC

Files 24

Run time 4s

Badge

Embed ▾

Committed 11 Feb 2020 - 15:31 coverage: 91.096%. Remained the same

Job # PHPCS_VERSION="dev-master" LINT=1 COVERALLS_VERSION="^2.0"

Build Type

Pull #82

travis-ci-com

Committed by

web-flow

Commit Message

FindEndOfStatementTest: simplify the tests

These are the same changes as pulled upstream in squizlabs/PHP_CodeSniffer 2866

* Use the `AbstractMethodUnitTest::getTargetToken()` method instead of doing a `findNext()` with a calculation.
    This makes the `$start` token retrieval more descriptive.
* Assert based on the token pointers, not the sub-array value.
    As for both the "expected" as well as "found" values, the token sub-array is retrieved from the same `$tokens` variable, if the token pointers are the same, the sub-arrays will be too, so doing the comparison based on the sub-array doesn't add any extra value to the test.
    Also: doing an array assertion is more expensive than doing a simple integer based assertion.
* Remove redundant calls to the `getTokens()` method.

Pull Request Pull Request #82: FindEndOfStatementTest: simplify the tests

Run Details

2169 of 2381 relevant lines covered (91.1%)

16.58 hits per line

PHPCSStandards / PHPCSUtils / 291 / 29

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 291.29 (PHPCS_VERSION="dev-master" LINT=1 COVERALLS_VERSION="^2.0")

PHPCSStandards / PHPCSUtils / 291 / 29

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 291.29 (PHPCS_VERSION="dev-master" LINT=1 COVERALLS_VERSION="^2.0")

README BADGES
x