4
100%
master: 100%

Ran 10 Feb 2020 12:58PM UTC

Files 2

Run time 0s

Badge

Embed ▾

Committed 10 Feb 2020 12:57PM UTC coverage: 100.0%. Remained the same

Job # 2.7

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix memoization with Hash-like objects as parameters (#25)

After adding `**kwargs` due to warnings in Ruby 2.7,
Hash-like parameters (with `#to_hash` method) convert to Hash
while passed in dynamically created by Memery method.
For example, instances of `Sequel::Model`.

Found Ruby bug: https://bugs.ruby-lang.org/issues/14909

So, changes will be in Ruby 2.8.

And for now we can:

1.  Use `**(;{})` as the additional parameter at method call, what is ugly.
2.  Define memoized methods with `eval` and exactly expected arguments,
    what is dangerous (eval is evil).
3.  Suppress warnings about keyword arguments until here are no failing tests.

First, I've chose the 3th.

But then Jeremy Evans suggest to use `ruby2_keywords`. So, here we're!

Additional line of code offensed RuboCop (method length),
so I was forced to refactor method definition.

Coverage Stats

281 of 281 relevant lines covered (100.0%)

4.0 hits per line

tycooon / memery / 90 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 90.4 (2.7)

tycooon / memery / 90 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 90.4 (2.7)

tycooon / memery / 90 / 4
100%
master: 100%

README BADGES
x