NZOI / nztrain / 747 / 1
33%
master: 38%

LAST BUILD BRANCH: feature/subtask-scoring
DEFAULT BRANCH: master
Ran
Files 153
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 33.143%. Remained the same
2.3.8

push

travis-ci

tom93 
Revert "Change v8 build directory from /v8-build to /tmp/v8-build"

It's not as simple as I thought and needs discussion.

The problem with using /tmp/v8-build is that another user might have
already created that directory. If we want the script to be safe in
the presence of malicious users on the same machine, we need another
approach:

1. Use ~/v8-build. Simple and safe. Won't be cleaned up automatically
   on reboot (unlike /tmp). I think this is the best option.

2. Use /v8-build. This only works when running as root; it would be
   useful if the script could also work for normal users.

3. Use /tmp/v8-build, but exit if mkdir fails and ask the user has to
   manually delete /tmp/v8-build (might exist from earlier builds).
   This is simple, but requires manual intervention in the case of
   failed builds and doesn't allow to resume build from previous
   state.

4. Use /tmp/v8-build, if mkdir fails delete it and try again. Similar
   to (3.) but doesn't require manual intervention.

5. Use /tmp/v8-build, if mkdir fails check ownership (`stat -c %u`)
   and abort if it's not the current one. Complex, but allows resuming
   build from previous state.

6. Use `mktemp` to create a different temporary directory each time.
   Failed builds would use up lots of space. Slightly harder to
   inspect build directory manually (need to find the directory name
   in the output of script).

2317 of 6991 relevant lines covered (33.14%)

4.75 hits per line

Source Files on job 747.1 (2.3.8)