4
93%
master: 93%

Ran 31 Jan 2020 12:08AM UTC

Files 20

Run time 1s

Badge

Embed ▾

Committed 30 Jan 2020 11:28PM UTC coverage: 92.737%. Remained the same

Job # 2464.4

Build Type

push

travis-ci-com

Committed by

BurntSushi

Commit Message

syntax: fix flag scoping issue

This fixes a rather nasty bug where flags set inside a group were being
applies to expressions outside the group. e.g., In the simplest case,
`((?i)a)b)` would match `aB`, even though the case insensitive flag
_shouldn't_ be applied to `b`.

The issue here was that we were actually going out of our way to reset
the flags when a group is popped only _some_ of the time. Namely, when
flags were set via `(?i:a)b` syntax. Instead, flags should be reset to
their previous state _every_ time a group is popped in the translator.

The fix here is pretty simple. When we open a group, if the group itself
does not have any flags, then we simply record the current state of the
flags instead of trying to replace the current flags. Then, when we pop
the group, we are guaranteed to obtain the old flags, at which point, we
reset them.

Fixes #640

Run Details

3690 of 3979 relevant lines covered (92.74%)

0.93 hits per line

rust-lang / regex / 2464 / 4
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2464.4

rust-lang / regex / 2464 / 4 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2464.4

rust-lang / regex / 2464 / 4
93%
master: 93%

README BADGES
x