tarantool
/
tarantool
/
20409
/
4
83%
master: 88%
master: 88%
|
Ran
|
Files
306
|
Run time
52s
|
Badge
Embed ▾
README BADGES
|
coverage: 82.382% (-0.1%) from 82.509%
push
travis-ci
kyukhintxn: don't trust group id in remote request header Transaction adds a redo log for each statement. The log is an xrow header. Some requests don't have a header (local requests), some do (from remote client, from replication). When a request had a header, it was written as is to WAL. But requests from remote client have an xrow header, however barely filled. Most of its fields are default values, usually 0. Including group id. Indeed, remote clients should not care about setting such deep system fields. That led to a problem when a space had group id local (!= 0), but it was ignored because in a request header from a remote client the group id was default (== 0). On the summary, it was possible to force Tarantool to replicate a replica-local space. Now group id setting is server-authoritative. Box always sets it regardless of what is present in an xrow header received from a client. Thanks Kostja Osipov (@kostja) for the diagnostics and the solution. Closes #4729 (cherry picked from commit a16637365)
41711 of 50631 relevant lines covered (82.38%)
909612.87 hits per line
