1
94%
master: 94%

Ran 05 May 2015 04:16AM UTC

Files 6

Run time 1s

Badge

Embed ▾

Committed 05 May 2015 04:13AM UTC coverage: 92.697% (+0.02%) from 92.676%

Job # 832.1

Build Type

Pull #618

travis-ci

Committed by

katowulf

Commit Message

Fixes #617 - $loaded() triggered too soon

Because of promisifying the $$added method, the child_added events were actually being processed internally after the loaded trigger. This occurred because $q.when() actually uses nextTick() internally as well, meaning the child_added events occurred immediately, but then $$process was not called until the second tick occurred; a difficult use case to catch.

The $loaded() event, meanwhile, had already triggered on the first tick. Solution was to promisify all the events and then remove the batch() wrapper since they trigger on nextTick() anyway now. So all events are back to firing in order on the next tick.

Pull Request Pull Request #618: Fixes #617 - $loaded() triggered too soon

Run Details

622 of 671 relevant lines covered (92.7%)

119.5 hits per line

firebase / angularfire / 832 / 1
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 832.1

firebase / angularfire / 832 / 1 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 832.1

firebase / angularfire / 832 / 1
94%
master: 94%

README BADGES
x