wikimedia / parsoid / 3258 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/512608d0c">Refactor Parsoid::html2html into Parsoid::pb2pb

Use the PageBundle class to indicate when we&#39;re dealing with separated
HTML, data-parsoid, and data-mw, with a new PageBundle::toHtml()
method to convert it back into &quot;unified&quot; (one HTML DOM, inline
attributes) form.

This is a useful marker in the code --- otherwise it&#39;s hard to tell if
a variable named $html is &quot;unified&quot; HTML or just one part of a page
bundle).  (Internally, there&#39;s another format used, where the data
attributes have been loaded into a separate bag structure attached
to the HTML, but that is not exposed in our external interfaces.)

Similarly, create explicit Parsoid::pb2pb and Parsoid::html2html
endpoints so the input types are clear.  While we&#39;re at it, add a pair
of missing ContentUtils::convertOffsets()/ConvertOffsets::run() calls
so (a) the Env &quot;request offset type&quot; parameter is honored on input, if
provided, (b) the &quot;current offset type&quot; parameter in the Env is
initialized correctly, and (c) the output offset type is correctly
recorded in the page bundle by ConvertOffsets::run().

We don&#39;t expect to use &quot;request offset type&quot; in production, so (b) and
(c) are actually the important things here, just to ensure that the
Env is initialized correctly and the page bundle records the fact
that these are (almost always) &quot;byte&quot; offsets.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/4a5918d7c">4a5918d7c</a>

Run Details

9662 of 12132 branches covered (79.64%)

15149 of 17854 relevant lines covered (84.85%)

32874.48 hits per line