1
99%
master: 99%

Ran 09 Jan 2020 01:43PM UTC

Files 3

Run time 0s

Badge

Embed ▾

Committed 09 Jan 2020 01:42PM UTC coverage: 98.936% (+0.004%) from 98.932%

Job # GO111MODULE=on

Build Type

push

travis-ci-com

Committed by

colega

Commit Message

Histograms: require buckets to be explicit

Default buckets were removed and buckets are now required: writing the
buckets is a 5 second effort while forgetting about them and having
wrong buckets in production is a lot of work (and maybe even an incident
if wrong buckets don't provide enough visibility on an issue)

So now any code without buckets on the histograms will fail to intialize
that metrics.

Finally, empty buckets tag is now allowed and it builds an empty buckets
slice, which will cause prometheus library to use its own default
buckets.

Notice that this change identified an issue in one of our own tests
where buckets tag was wrong (`metricsbuckets`) and it was unnoticed
because default buckets where used instead.

Run Details

279 of 282 relevant lines covered (98.94%)

11.02 hits per line

cabify / gotoprom / 146 / 1
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 146.1 (GO111MODULE=on)

cabify / gotoprom / 146 / 1 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 146.1 (GO111MODULE=on)

cabify / gotoprom / 146 / 1
99%
master: 99%

README BADGES
x