nmstate / nmstate / 4050 / 1

Ran 08 Jan 2020 03:24PM UTC

Files 29

Run time 3s

Badge

Committed 08 Jan 2020 03:15PM UTC coverage: 88.889% (+0.07%) from 88.815%

Job # testflags="--test-type integ --pytest-args='-x'" use_codecov=false DOCKER_IMAGE=nmstate/centos8-nmstate-dev use_coveralls=true

Build Type

push

travis-ci-com

Committed by

tyll

Commit Message

nm.device: Deletion: Assume removed interface as success

Instead of making various and wrong assumption in
`_delete_device_callback()` which errors mean that the interface is
removed, just check if the interface is not there anymore. This will
also handle failures like `nm-device-error-quark: This device is not a
software device or is not realized (5)` or `error=nm-client-error-quark:
Object is no longer in the client cache (0)` that were not caught by the
previous code. When these errors happened or probably when
`NMDevice.is_real()` returns `False`, `NMDevice.get_iface()` returns
`None`. Therefore get the interface earlier to have it available in the
callback. A better solution might be to refactor Nmstate to properly
pass a context about which part of the desired state is handled in each
async call to ensure the interface name and possibly other useful
information is always present.

Signed-off-by: Till Maas <opensource@till.name>

Run Details

1920 of 2160 relevant lines covered (88.89%)

0.89 hits per line

Source Files on job 4050.1 (testflags="--test-type integ --pytest-args='-x'" use_codecov=false DOCKER_IMAGE=nmstate/centos8-nmstate-dev use_coveralls=true)

nmstate / nmstate / 4050 / 1

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4050.1 (testflags="--test-type integ --pytest-args='-x'" use_codecov=false DOCKER_IMAGE=nmstate/centos8-nmstate-dev use_coveralls=true)

nmstate / nmstate / 4050 / 1

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4050.1 (testflags="--test-type integ --pytest-args='-x'" use_codecov=false DOCKER_IMAGE=nmstate/centos8-nmstate-dev use_coveralls=true)

README BADGES
x