11
92%
master: 91%

Ran 28 Dec 2019 02:58AM UTC

Files 42

Run time 2s

Badge

Embed ▾

Committed 28 Dec 2019 02:53AM UTC coverage: 88.602% (-0.03%) from 88.636%

Job # PKGS="python=3.7 numpy=1.14 uncertainties=3.0"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge #842

842: Missing conversion definition when mutating context transformations. r=hgrecco a=dcupif

Thanks for the library, we use it at our company and it's proven
really helpful so far. We are currently moving to Python 3.7 which
made me spot a potential bug in the `BaseRegistry` class (some
of our tests failed when upgrading).

Everything runs fine in Python 3.5, but in 3.7, we are getting a
`DimensionalityError` resulting from the ill-definition of a conversion.
Root cause is that we are mutating context transformations while
iterating over it.

This PR aims to avoid this potential problem. Since we modify the
transformations dictionary structure while iterating over it, we may
fail to iterate over all entries.

Explanation: "Iterating views while adding or deleting entries in the
dictionary may raise a `RuntimeError` or fail to iterate over all
entries"

https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects

This is my first time contributing to Pint, so please let me know if
something needs to be improved / changed.

Co-authored-by: Damien Cupif <dcupif@kpler.com>

Run Details

7556 of 8528 relevant lines covered (88.6%)

0.89 hits per line

hgrecco / pint / 1486 / 11
92%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1486.11 (PKGS="python=3.7 numpy=1.14 uncertainties=3.0")

hgrecco / pint / 1486 / 11 92% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1486.11 (PKGS="python=3.7 numpy=1.14 uncertainties=3.0")

hgrecco / pint / 1486 / 11
92%
master: 91%

README BADGES
x