firebase / firebase-js-sdk / 10754 / 1

0%

master: 0%

push

travis-ci

Fix flaky RTDB tests due to increment operations. (#2466)

The introduction of tests that try to send increment operations to the backend has resulted in test flakiness.  Basically the emulator rejects these as invalid operations and closes the connection.  The client automatically reconnects, so _usually_ this doesn't matter.  But the SDK intentionally doesn't tolerate disconnects in the middle of a transaction, so if the disconnect happens to happen during a transaction test, then the test will fail.

I'm avoiding the problem by isolating the increment tests better (use an isolated instance of RTDB and ensures it remains offline so it doesn't even try to send the requests to the emulator).

I've opened b/146657568 to track cleaning this up once the emulator supports increment operations.

6753 of 8246 branches covered (81.89%)

Branch coverage included in aggregate %.

21162 of 22854 relevant lines covered (92.6%)

4208.06 hits per line