uken / fluent-plugin-elasticsearch / 1518 / 4

90%

master: 94%

Build Type

push

travis-ci

Committed by Hiroshi Hatake

Commit Message

<a href="https://github.com/uken/fluent-plugin-elasticsearch/commit/<a class=hub.com/uken/fluent-plugin-elasticsearch/commit/039455335e6c493d032e3e0a2a52595b04650d60">039455335<a href="https://github.com/uken/fluent-plugin-elasticsearch/commit/039455335e6c493d032e3e0a2a52595b04650d60">&quot;&gt;Unblock when buffer overflow action is block

Fluentd stuck was occurred with the following scenario:

* flushing thread try Output::write
* fluent-plugin-elasticsearch try to write
* It fails to write since Elasticsearch is freezed
* It try Output::emit_buffered to write back the chunk
* It cannot write to the buffer since buffer is full.
* When overflow_action is :block, it can&amp;#39;t return from the following loop because write of fluent-plugin-elasticsearch never be called until exiting from this loop:
  * https://github.com/fluent/fluentd/blob/</a><a class="double-link" href="https://github.com/uken/fluent-plugin-elasticsearch/commit/<a class="double-link" href="https://github.com/uken/fluent-plugin-elasticsearch/commit/fcef949ce40472547fde295ddd2cfe297e1eddd6">fcef949ce</a>">fcef949ce</a><a href="https://github.com/uken/fluent-plugin-elasticsearch/commit/039455335e6c493d032e3e0a2a52595b04650d60">/lib/fluent/plugin/output.rb#L896-L904
* It can&#39;t recover even if Elasticsearch is unfreezed since above infinite loop never exit.

RetryStream feature is for sending another Elasticsearch cluster instead of exhausted Elasticsearch destination.
But previous implementation for RetryStream caontains dangerous
operation when buffer is fullfilled another buffer.

Co-authored-by: Ashie Takuro <ashie@clear-code.com>

Run Details

1012 of 1126 relevant lines covered (89.88%)

193.48 hits per line