2
94%
master: 95%

Ran 18 Dec 2019 04:26PM CUT

Files 15

Run time 1s

Badge

Committed 18 Dec 2019 04:24PM CUT coverage: 93.598% (+0.07%) from 93.528%

Job # CXX=g++ CC=gcc DO_Coverage=ON BUILD_TOOL="Unix Makefiles" BUILD_TYPE=Debug LIB_TYPE=shared DESTDIR=/tmp/cmake_json_cpp

Build Type

Pull #1120

travis-ci

Committed by

web-flow

Commit Message

json_writer: fix inverted sense in isAnyCharRequiredQuoting

This bug is only affects platforms where `char` is unsigned.

When char is a signed type, values >= 0x80 are also considered < 0,
and hence require escaping due to the < ' ' condition.

When char is an unsigned type, values >= 0x80 match none of the
conditions and are considered safe to emit without escaping.

This shows up as a test failure:

* Detail of EscapeSequenceTest/writeEscapeSequence test failure:
/build/source/src/test_lib_json/main.cpp(3370): expected == result
  Expected: '["\"","\\","\b","\f","\n","\r","\t","\u0278","\ud852\udf62"]
  '
  Actual  : '["\"","\\","\b","\f","\n","\r","\t","ɸ","𤭢"]
  '

Pull Request Pull Request #1120: json_writer: fix inverted sense in isAnyCharRequiredQuoting

Run Details

2763 of 2952 relevant lines covered (93.6%)

801.46 hits per line

Source Files on job 1581.2 (CXX=g++ CC=gcc DO_Coverage=ON BUILD_TOOL="Unix Makefiles" BUILD_TYPE=Debug LIB_TYPE=shared DESTDIR=/tmp/cmake_json_cpp)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
87.5	src/lib_json/json_tool.h	134	40	35	5	407.0
92.51	src/lib_json/json_reader.cpp	1990 + 1800	1189 + 1106	1100 + 1076	89 + 30	210.0 + 209
92.93	src/lib_json/json_value.cpp	1629 + 1627	849 + 848	789 + 788	60 + 60	2382.0 + 2381
95.29	src/lib_json/json_writer.cpp	1260 + 1	743 + 1	708 + 3	35 - 2	113.0 - 38
100.0	include/json/json_features.h	67	1	1	0	64.0
100.0	include/json/json.h	15 + 13	0 - 1	0 - 1	0	0.0 - 1.0
100.0	include/json/reader.h	403	8	8	0	212.0
100.0	include/json/allocator.h	89 + 81	0 - 5	0 - 4	0 - 1	0.0 - 1.0
100.0	include/json/version.h	28	0	0	0	0.0
100.0	include/json/writer.h	367	9	9	0	72.0

100.0
include/
93.45
src/

open-source-parsers / jsoncpp / 1581 / 2
94%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1581.2 (CXX=g++ CC=gcc DO_Coverage=ON BUILD_TOOL="Unix Makefiles" BUILD_TYPE=Debug LIB_TYPE=shared DESTDIR=/tmp/cmake_json_cpp)

open-source-parsers / jsoncpp / 1581 / 2 94% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1581.2 (CXX=g++ CC=gcc DO_Coverage=ON BUILD_TOOL="Unix Makefiles" BUILD_TYPE=Debug LIB_TYPE=shared DESTDIR=/tmp/cmake_json_cpp)

open-source-parsers / jsoncpp / 1581 / 2
94%
master: 95%

README BADGES
x