6
34%
master: 34%

Ran 16 Dec 2019 03:14AM UTC

Files 35

Run time 2s

Badge

Embed ▾

Committed 16 Dec 2019 03:10AM UTC coverage: 33.107% (+0.2%) from 32.863%

Job # 449.6

Build Type

push

travis-ci

Committed by

josephlr

Commit Message

keyring: fix permission denied accessing user keyring (#177)

When userKeyringIDLookup() looks up a user keyring, it links it into the
process keyring to ensure that the process retains the "possessor
privileges" over the user keyring, then caches the user keyring's ID.

Unfortunately, this use of the process keyring randomly fails because Go
creates threads before even init() and main() are run, and then can run
code on them later.  Since the kernel doesn't create the process keyring
until userspace requests it and the process keyring is actually a
per-thread property that's only inherited by new threads, different
threads in a Go process may see different process keyrings.

Fix this by removing the user keyring cache, switching from the process
keyring to the thread keyring, and using LockOSThread() to pin the
goroutine to an OS thread while needed to perform a keyring operation.

Resolves https://github.com/google/fscrypt/issues/176

Run Details

1367 of 4129 relevant lines covered (33.11%)

1235.45 hits per line

google / fscrypt / 449 / 6
34%
master: 34%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 449.6

google / fscrypt / 449 / 6 34% master: 34%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 449.6

google / fscrypt / 449 / 6
34%
master: 34%

README BADGES
x