frictionlessdata / tableschema-js / 576 / 2

90%

master: 90%

push

travis-ci

Fix binary format implementation (#161)

Base64 strings end with 0, 1 or 2 '=' characters. It's incorrect to
assume that they always end with "==".

I think we also have to remove inference for binary strings because:

- almost all "normal" strings which length is a multiple of 4 are also valid
  base64 strings
- we could detect if the strings end with a '=' character. But this
  would only occur with a probability of 2/3, whereas the threshold is
  set to 0.75 (`const INFER_CONFIDENCE = 0.75`)

442 of 520 branches covered (85.0%)

Branch coverage included in aggregate %.

812 of 873 relevant lines covered (93.01%)

1991.6 hits per line