1
57%
master: 57%

Ran 26 Apr 2015 01:48AM UTC

Files 523

Run time 2min

Badge

Embed ▾

Committed 26 Apr 2015 01:32AM UTC coverage: 40.516% (+0.003%) from 40.513%

Job # 650.1

Build Type

Pull #243

travis-ci

Committed by

yodalee

Commit Message

fix crash when close file with editText focus

The repeat steps:
1. Open a schematic file.
2. Focus on a component property, show the property edit
3. Close the file
4. The program will crash

The source:
This bug is appeared since commit eadd7b

The cause:
When click on property edit, this line
qucs_action.cpp:1221, editText->reparent(...
will change the editText to child of the open document
At this time, if the document is closed, the editText will
be deleted by Qt
After that, qucs try to access to editText will access to invalid
memory.

The fix:
To be general, now editText will child of main app every time the
slotHideEdit() called, it's a little overhead, but guarantee safe.
function slotHideEdit() {
  ...
  editText->setParent(this, 0);
}

Pull Request Pull Request #243: fix crash when close file with editText focus

Coverage Stats

13496 of 33310 relevant lines covered (40.52%)

347504.4 hits per line

Qucs / qucs / 650 / 1
57%
master: 57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 650.1

Qucs / qucs / 650 / 1 57% master: 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 650.1

Qucs / qucs / 650 / 1
57%
master: 57%

README BADGES
x