3
99%
master: 99%

Ran 29 Nov 2019 06:13PM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 29 Nov 2019 06:11PM UTC coverage: 98.54% (+0.003%) from 98.537%

Job # 2.5

Build Type

Pull #118

travis-ci

Committed by

web-flow

Commit Message

Adds support for nested elements named 'class'

Defining an item named 'class', as in
```
class Msg
  include HappyMapper

  has_one :'class', String
end

Msg.parse('<msg></msg>')
```
currently fails with
`lib/happymapper.rb:489:in `initialize': undefined method `attributes' for nil:NilClass (NoMethodError)`

The reason is that the .class method of the HappyMapper object is
overridden and all uses of self.class, starting with the one in
`initialize`, will fail.

The spec modification in this commit demonstrates another aspect of this
problem (when applied without the other changes) and can serve as a guard
against regression.

The fix is to add __class__ as an alias of class. Of course, if anyone ever
needs __class__ as an item, they will run into the same problem.
However, a generic solution adds a lot more complexity and needing __class__
is (much?) less likely than 'class'.

Pull Request Pull Request #118: Adds support for nested elements named 'class'

Run Details

405 of 411 relevant lines covered (98.54%)

295.08 hits per line

mvz / happymapper / 76 / 3
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 76.3 (2.5)

mvz / happymapper / 76 / 3 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 76.3 (2.5)

mvz / happymapper / 76 / 3
99%
master: 99%

README BADGES
x