7
66%
master: 66%

Ran 26 Nov 2019 06:56PM UTC

Files 109

Run time 7s

Badge

Embed ▾

Committed 26 Nov 2019 06:43PM UTC coverage: 64.588% (-0.01%) from 64.602%

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

SA: conditionally track issued names in AddPrecertificate. (#4573)

Prev. we inserted data for tracking issued names into the `issuedNames` table
during `sa.AddCertificate`. A more robust solution is to do this during
`sa.AddPrecertificate` since this is when we've truly committed to having
issued for the names.

The new SA `WriteIssuedNamesPrecert` feature flag enables writing this table
during `AddPrecertificate`. The legacy behaviour continues with the flag
enabled or disabled but is updated to tolerate duplicate INSERT errors so that
it is possible to deploy this change across multiple SA instances safely.

Along the way I also updated `SA.AddPrecertificate` to perform its two
`INSERT`s in a transaction using the `db.WithTransaction` wrapper.

Resolves https://github.com/letsencrypt/boulder/issues/4565

Coverage Stats

11912 of 18443 relevant lines covered (64.59%)

0.72 hits per line

letsencrypt / boulder / 11553 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11553.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11553 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11553.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11553 / 7
66%
master: 66%

README BADGES
x