• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

benmvp / bart-salmon / 167 / 1
52%
master: 52%

Build:
DEFAULT BRANCH: master
Ran 23 Nov 2019 07:31PM UTC
Files 32
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Nov 2019 04:52PM UTC coverage: 57.487%. Remained the same
167.1

push

travis-ci

web-flow
Update salmon routes UI (#40)

## Problem

The salmon routes UI was the quick & dirty UI I built early on to iterate on the algorithm and test it out in the wild. It has wrapping problems, is missing the number of trains, and just wasn't visually appealing.

## Solution

Completely restyled the salmon routes UI to fix all the wrapping problems and to make it more visually appealing. Also made full use of [`material-ui`'s](https://material-ui.com/) component library and css-in-js [styling solution](https://material-ui.com/styles/basics/). The route UI is now an [`ExpansionPanel`](https://material-ui.com/components/expansion-panels/), using [`Box`](https://material-ui.com/components/box/) & [`Grid`](https://material-ui.com/components/grid/) to layout the UI. Wordy text has been replaced by [`Badge`s](https://material-ui.com/components/badges/), [`Chip`s](https://material-ui.com/components/chips/), and [iconography](https://material-ui.com/components/material-icons/). This allowed me to greatly simplify & limit the CSS used.

The backwards (aka salmon) station and the additional time taking the route are the two most important pieces of information and are what are shown for every route in the expansion panels. You must tap into a given panel to expose the backwards train, the returning train and the wait times for each. Only one set of details will show at a time, making the expansion panels act more like an accordion.

I also made the refresh button at the top size `'small'` so that it doesn't take up as much height.

NOTE: The [`Arrivals` section](https://github.com/benmvp/bart-salmon/blob/master/src/components/Arrivals.tsx) in the middle will be updated in a follow-up PR.

## Screenshots

| Before | After |
| ------ | ----- |
| <img width="380" alt="Screen Shot 2019-11-21 at 10 31 23 PM" src="https://user-images.githubusercontent.com/5714478/69403175-c2302780-0cae-11ea-9bc9-6ce726b4cabf.png"> | <img width="378" alt="Screen Shot 2019... (continued)

98 of 168 branches covered (58.33%)

215 of 374 relevant lines covered (57.49%)

9039.66 hits per line

Source Files on job 167.1
  • Tree
  • List 0
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 142
  • Travis Job 167.1
  • d96b5f9f on github
  • Prev Job for on master (#165.1)
  • Next Job for on master (#170.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc