7
66%
master: 66%

Ran 18 Nov 2019 06:40AM UTC

Files 109

Run time 8s

Badge

Embed ▾

Committed 15 Nov 2019 09:03PM UTC coverage: 64.216%. Remained the same

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

cron

travis-ci

Committed by

web-flow

Commit Message

bdns: move logDNSError to exchangeOne, log ErrId specially. (#4553)

We've found we need the context offered from logging the error closer to when it
happens in the `bdns` package rather than in the `va`. Adopting the function
requires adapting it slightly. Specifically in the new location we know it won't
be called with any timeout results, with a non-dns error, or with a nil
underlying error.

Having the logging done in `bdns` (and specifically from `exchangeOne`) also
lets us log the wire format of the query and response when we get a `dns.ErrId`
error indicating a query/response ID mismatch. A small unit test is included
that ensures the logging happens as expected.

In case it proves useful for matching against other metrics the DNS ID mismatch
error case also now increments a dedicated prometheus counter vector stat,
`dns_id_mismatch`. The stat is labelled by resolver and query type.

Resolves https://github.com/letsencrypt/boulder/issues/4532

Run Details

11765 of 18321 relevant lines covered (64.22%)

0.72 hits per line

letsencrypt / boulder / 11514 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11514.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11514 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11514.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11514 / 7
66%
master: 66%

README BADGES
x