wikimedia / parsoid / 3169 / 2

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/742034151">Add handling for new / missing pages in html2wt direction

* We currently unconditionally construct a PageConfigFrame in
  html2wt even though it is not used. The idea is that eventually,
  both wt2html and html2wt will use PageConfigFrame for accessing
  page content.

* But, PageConfigFrame didn&#39;t know anything about missing / new
  titles and was barfing in html2wt mode.

* Pass along information in html2wt mode whether a title is expected
  to exist or not so that PageContentFrame can be strict or lenient
  about throwing exceptions, as recommended in T234549.

  If title is not known to exist, it initializes itself to &#39;&#39;.

* Change the changeEnv signature in ParsoidHandler to make
  titleShouldExist a required argument so that we didn&#39;t have
  different values of defaults here and in PageConfigFrame.

  The explicitness also makes for better documentation anyway.

* A related issue is T235307. An env object is constructed in the
  REST handlers for internal use and discarded only to be built again
  in Parsoid&#39;s entry points. So, we had two places for the exception
  to be thrown. This is handled uniformly now by passing along
  information about whether title exists or not.

Bug: T234549
Bug: T238161
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/055075ed5">055075ed5</a>

Run Details

9659 of 12132 branches covered (79.62%)

15134 of 17830 relevant lines covered (84.88%)

32611.57 hits per line