1
77%
develop: 77%

Ran 11 Nov 2019 08:32AM UTC

Files 25

Run time 2s

Badge

Embed ▾

Committed 11 Nov 2019 08:29AM UTC coverage: 78.215%. Remained the same

Job # FRONTEND=1 UNIT=1

Build Type

push

travis-ci

Committed by

FinalAngel

Commit Message

Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738)

* Refs #6737 -- Add test for apphooks urls config check

* Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls

When rewriting the apphooks urls in appresolver.recurse_patterns,
the original RegexPattern.is_endpoint flag is lost, so urls with a callback
view throws an "include with a route ending with a '$'" warning ('urls.W001').

    @apphook_pool.register
    class MyApp(CMSApp):
        name = "MyApp"

        def get_urls(self, page=None, language=None, **kwargs):
            return [
                re_path(r"^$", views.MyAppView.as_view(), name="my-app-index")
                # or this
                # path(r"", views.MyAppView.as_view(), name="my-app-index")
            ]

    $ ./manage.py check
    System check identified some issues:

    WARNINGS:
    ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index']
    uses include with a route ending with a '$'. Remove the dollar from the
    route to avoid problems including URLs.

This fix set the RegexPattern flag is_endpoint to True for callback views
in appresolver.recurse_patterns as in
https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70

Run Details

2542 of 3250 relevant lines covered (78.22%)

34.22 hits per line

divio / django-cms / 10879 / 1
77%
develop: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10879.1 (FRONTEND=1 UNIT=1)

divio / django-cms / 10879 / 1 77% develop: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10879.1 (FRONTEND=1 UNIT=1)

divio / django-cms / 10879 / 1
77%
develop: 77%

README BADGES
x