samsarahq / thunder / 2182 / 1
62%
master: 66%

LAST BUILD BRANCH: dependabot/npm_and_yarn/client/ua-parser-js-0.7.33
DEFAULT BRANCH: master
Ran
Files 49
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.206% (+0.005%) from 62.201%
2182.1

Pull #334

travis-ci

web-flow 
go livesql/binlog: set Localhost in binlogSyncerConfig

This sets the hostname of the slave hosts to be "localhost". If unset,
as it was, it will use the os.Hostname() value as the hostname instead.

In rare situations, the OS's hostname could be too long for the slave
host's "host" field, and we got an error like:

  panic: ERROR 1105 (HY000): Failed to register slave: too long 'report-host'

which would crash the server.

Before this change:
mysql> show slave hosts;
+------------+--------------------------+------+-----------+------------+
| Server_id  | Host                     | Port | Master_id | Slave_UUID |
+------------+--------------------------+------+-----------+------------+
| 2926146535 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 4101280766 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
|  738891311 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3490062834 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3176772553 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
|  985189460 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 4240725287 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 2752132824 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3221796892 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
| 3038601891 | Arthur-Huang-MacBook-Pro | 3308 |         1 |            |
+------------+--------------------------+------+-----------+------------+

After this change:
mysql> show slave hosts;
+------------+-----------+------+-----------+------------+
| Server_id  | Host      | Port | Master_id | Slave_UUID |
+------------+-----------+------+-----------+------------+
|  186920018 | localhost | 3308 |         1 |            |
| 2071718504 | localhost | 3308 |         1 |            |
| 3278845420 | localhost | 3308 |         1 |            |
| 2121800266 | localhost | 3308 |         1 |            |
| 3721418580 | loc... (continued)
Pull Request #334: go livesql/binlog: set Localhost in binlogSyncerConfig

4342 of 6980 relevant lines covered (62.21%)

14429.64 hits per line

Source Files on job 2182.1