codevise / pageflow / 3135 / 2
99%
master: 99%

LAST BUILD BRANCH: fix-before-after-dimensions
DEFAULT BRANCH: master
Ran
Files 460
Run time 24s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 99.267% (-0.001%) from 99.268%
2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true

Pull #1233

travis-ci

web-flow 
Prevent further cases of perma id clashes

Wrapping `RevisionComponent#save` in an advisory lock, does not
suffice for cases where the revision component is created through an
association, i.e

    revision.file_usages.create!(...)

In this case `CollectionAssociation#_create_record` [1] already starts
the transaction before the lock is required. Since the transaction is
then committed only after the advisory lock is already released, the
following race condition can occur:

    Thread 1:                       Thread 2:
    |                               |
    BEGIN                           |
    GET LOCK                        |
    SELECT MAX perma_id             |
    INSERT revision component       |
    RELEASE LOCK                    |
    |                               BEGIN
    |                               GET LOCK
    |                               SELECT MAX perma_id
    COMMIT                          |
    |                               INSERT revision component
    |                               RELEASE LOCK
    |                               COMMIT

Since the first transaction is not yet finished, the second thread
does not yet see the newly inserted perma id and calculates the same
maximum.

To ensure that the lock is acquired before the transaction starts, we
add a new class method `create_with_lock!` which then delegates to
`create!`.

For existing revision components (and models that behave like revision
components like `Page`) this race condition has never been a problem
since concurrent inserts are not that likely within a revision (and we
do not care about non-unique perma ids accross entries). We only
noticed the problem for file usages now since those are created by a
batch of requests when multiple files are uploaded at the same time.
So for now we use the new `create_with_lock!` method only in
`DraftEntry.create_file!`.

[1] https://github.com/rails/rails/blob/b9ca94cae/activerecord/lib... (continued)
Pull Request #1233: Prevent further cases of perma id clashes

17194 of 17321 relevant lines covered (99.27%)

29.98 hits per line

Source Files on job 3135.2 (2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)