5
100%
master: 100%

Ran 28 Oct 2019 12:14PM UTC

Files 32

Run time 3s

Badge

Embed ▾

Committed 28 Oct 2019 12:09PM UTC coverage: 0.0%. Remained the same

Job # jruby-9.1.9.0

Build Type

push

travis-ci

Committed by

dmagliola

Commit Message

Fix bug where different label orders lead to different results

In the DirectFileStore, in order to store the labels hash on disk, we
turn it into a "querystring". The way this is done, we'll end up with
different strings if the same hash is passed in with its keys in
different order.

Since this string is used to index into the file where we store the data,
this will lead to two different values being stored for the same hash.
This is fine in cases where the aggregation is :SUM, because they end up
getting summed when the Client is summarizing. But in :ALL aggregation,
for example, you will end up with one value or the other, randomly.

The test in this commit reproduces this problem.

This way of serializing the labels is a bit slower (see PR for details),
but it's not a huge impact in the big scheme of things, and it leads to
the correct result.

Signed-off-by: Daniel Magliola <danielmagliola@gocardless.com>

Run Details

0 of 1501 relevant lines covered (0.0%)

0.0 hits per line

prometheus / client_ruby / 532 / 5
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 532.5 (jruby-9.1.9.0)

prometheus / client_ruby / 532 / 5 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 532.5 (jruby-9.1.9.0)

prometheus / client_ruby / 532 / 5
100%
master: 100%

README BADGES
x