ckeditor / ckeditor5-dev / 2698 / 1

90%

master: 90%

push

travis-ci

Merge pull request #568 from ckeditor/t/ckeditor5/1746

Other: Changed rules how changelog generators work. See: ckeditor/ckeditor5#1746.

- Notes from all commits will be saved in the changelog before "Features", "Bug fixes", "Other changes". They have been moved from the bottom to the top.
- Introduced new types of notes:
    * `MAJOR BREAKING CHANGES` which means that the public API of the package has been changed,
    * `MINOR BREAKING CHANGES` which means that the public API of the package has not been changed but some internals (utils, helpers, etc.) have changed.
- `BREAKING CHANGES` are treated as `MAJOR BREAKING CHANGES`,
- Before starting the generating changelog process, all `MAJOR BREAKING CHANGES` commits are printed out. A user must confirm whether those changes are really "MAJOR". The user can specify the version number but the commit list won't be shown.
- If the user confirms major changes, the tool will bump `major` versions for all packages.
- If the user rejects (no major changes), the tool will bump `minor|patch|internal` based on commits in packages. All commits will be printed out.
- Removed support for `options.newVersion` in `generateChangelogForSubRepositories()` and `generateSummaryChangelog()` tasks.
- `transformCommitForSubPackage()` and `transformCommitForSubRepository()` are "factories" now. They return a new function that parses the commit. See the "BREAKING CHANGES" section.

BREAKING CHANGES: `generateChangelogForSubRepositories()` and `generateSummaryChangelog()` do not accept `options.newVersion` as an option anymore.

BREAKING CHANGES: `transformCommitForSubPackage()` and `transformCommitForSubRepository()` end with a suffix `Factory` (included as lower case in their file names). Now those functions return a new function that parses the commit (module replaced with a factory pattern). The `returnInvalidCommit` option was moved from `context` object to a factory function (as `options`).

NOTE: `gene... (continued)

794 of 904 branches covered (87.83%)

Branch coverage included in aggregate %.

2286 of 2463 relevant lines covered (92.81%)

19.73 hits per line