2
97%
master: 97%

Ran 21 Oct 2019 09:43AM UTC

Files 109

Run time 7s

Badge

Embed ▾

Committed 21 Oct 2019 09:41AM UTC coverage: 96.886% (-0.3%) from 97.164%

Job # 1317.2

Build Type

push

travis-ci

Committed by

NamelessCoder

Commit Message

[BUGFIX] Use magic getter method as last attempt (#480)

* [BUGFIX] Use magic getter method as last attempt

Prevents issues with greedy magic methods being
called when a (public) property of the same name
exists in the class.

Specifically, does the following:

* Reverts deprecated VariableExtractor to previous
  behavior of letting a PHP warning be raised for
  protected getter methods. Removes the test that
  asserted this behavior (but kept it for StandardVariableProvider!)
* Switches both method_exists() and is_callable() to
  use instead a "study object" method that extracts
  all PUBLIC methods, disregarding __call, and fixing
  the problem that method_exists() returns TRUE for
  protected methods, and the problem that is_callable()
  returns TRUE for literally any method name.
* Slightly improves the internal logic of StandardVariableProvider
  and refactors it to call the "study object" method
  before checking if getters or asserter methods exist.

Close: #479

* [TASK] Rename studyObject to populateGettersByClassName

Clarify that method populates an array.

Run Details

2645 of 2730 relevant lines covered (96.89%)

45.69 hits per line

TYPO3 / Fluid / 1317 / 2
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1317.2

TYPO3 / Fluid / 1317 / 2 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1317.2

TYPO3 / Fluid / 1317 / 2
97%
master: 97%

README BADGES
x