7
66%
master: 66%

Ran 18 Oct 2019 06:06PM UTC

Files 109

Run time 12s

Badge

Embed ▾

Committed 18 Oct 2019 05:53PM UTC coverage: 61.393%. Remained the same

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

log: panic if bothWriter write to stdout errs. (#4491)

If we can't write to stdout we prefer to panic immediately rather than
potentially lose logs we capture from redirecting stdout as a syslog backup.

A unit test is included to verify the panic behaviour. Prior to the `log` diff
in this branch the test failed because the non-nil `err` result from
`fmt.Printf` was being away:

```
=== RUN   TestStdoutFailure
=== PAUSE TestStdoutFailure
=== CONT  TestStdoutFailure
FAIL	github.com/letsencrypt/boulder/log	0.011s
FAIL
```

After the `log` package diff in this branch is applied the test passes.

I additionally tested this end-to-end by redirecting stdout to a full
filesystem volume mounted into the Boulder docker image. It provoked the
expected panic when a component tried to write to stdout and the filesystem was
full.

Run Details

11882 of 19354 relevant lines covered (61.39%)

0.69 hits per line

letsencrypt / boulder / 11343 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11343.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11343 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11343.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 11343 / 7
66%
master: 66%

README BADGES
x