2
68%
develop: 68%

Ran 11 Oct 2019 05:12PM UTC

Files 207

Run time 22s

Badge

Embed ▾

Committed 11 Oct 2019 04:24PM UTC coverage: 16.321%. Remained the same

Job # TESTING_PROFILE=unit-tests

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Add row level security policy to join table (#2954)


#2849 

The table version_sourcefiles is a join table for the
sourcefile table and the workflowversion/tag tables.

If version is frozen, don't allow modifications --
no adding of additional source files, deletion nor modification
of existing ones.

Part of the ticket was to remove the application guards once database protection
was implemented, but I decided against that -- Hibernate throws a 500 exception
in that case. We would need to catch that exception and throw our own exception.
The problem is the exception is thrown after the return statement code in the
Java code for the resource endpoint -- the error happens because the @UnitOfWork
annotation causes Hibernate to attempt to commit the transaction. We would have
to remove the annotation, manually start the transaction and commit it. Which is
doable, but doesn't seem like it would offer much over the current application
guards.

Coverage Stats

1773 of 10863 relevant lines covered (16.32%)

0.32 hits per line

dockstore / dockstore / 10065 / 2
68%
develop: 68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10065.2 (TESTING_PROFILE=unit-tests)

dockstore / dockstore / 10065 / 2 68% develop: 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10065.2 (TESTING_PROFILE=unit-tests)

dockstore / dockstore / 10065 / 2
68%
develop: 68%

README BADGES
x