1
96%
master: 97%

Ran 01 Oct 2019 04:53PM UTC

Files 97

Run time 8s

Badge

Embed ▾

Committed 01 Oct 2019 04:52PM UTC coverage: 96.188% (+0.006%) from 96.182%

Job # 2.3

Build Type

Pull #857

travis-ci

Committed by

web-flow

Commit Message

Move to monotonic time for duration calculations

Drops the use of `Time.now` in favor of using the system's monotonic
clock for various operations that calculate and use elapsed duration.
The latter is preferable because in some cases `Time.now` can be
unstable, like if it's set manually by a system administrator or an NTP
daemon.

I don't expect that the previous code would actually have caused trouble
in the vast majority of normal situations, so I'm not going to backport
anything, but this seems like good hygiene.

For better or worse I had to wrap the monotonic time calls in a new
`Util` function because (1) the normal invocation is long enough to have
caused a lot of overruns on our 80 character line lengths, and (2)
Timecop doesn't stub the monotonic clock, so the `Util` method gives us
a nice place that we can stub on where necessary.

Pull Request Pull Request #857: Move to monotonic time for duration calculations

Coverage Stats

1943 of 2020 relevant lines covered (96.19%)

612.56 hits per line

stripe / stripe-ruby / 3458 / 1
96%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3458.1 (2.3)

stripe / stripe-ruby / 3458 / 1 96% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3458.1 (2.3)

stripe / stripe-ruby / 3458 / 1
96%
master: 97%

README BADGES
x