5
66%
master: 66%

Ran 01 Oct 2019 03:03PM UTC

Files 870

Run time 1min

Badge

Embed ▾

Committed 01 Oct 2019 01:45PM UTC coverage: 63.374% (+0.001%) from 63.373%

Job # COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765"

Build Type

push

travis-ci

Committed by

nmathewson

Commit Message

Add comments to try to prevent recurrence of #31495.

There is a bad design choice in two of our configuration types,
where the empty string encodes a value that is not the same as the
default value.  This design choice, plus an implementation mistake,
meant that config_dup() did not preserve the value of routerset_t,
and thereby caused bug #31495.

This comment-only patch documents the two types with the problem,
and suggests that implementors try to avoid it in the future.

Closes ticket 31907.

Run Details

47977 of 75704 relevant lines covered (63.37%)

48246.84 hits per line

torproject / tor / 6482 / 5
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6482.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765")

torproject / tor / 6482 / 5 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6482.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765")

torproject / tor / 6482 / 5
66%
master: 66%

README BADGES
x