3
91%
master: 91%

Ran 09 Apr 2015 06:33PM UTC

Files 105

Run time 7s

Badge

Embed ▾

Committed 09 Apr 2015 06:24PM UTC coverage: 89.186% (+0.05%) from 89.134%

Job # 2.1

Build Type

push

travis-ci

Committed by

sds

Commit Message

Add test ensuring empty submodule directories are removed

This threw me for a loop for a little while because of the differences
in behavior between git 1.8 and 2.3 (the versions I run on CentOS and
Mac OS X, respectively).

In git 1.8, you can't stash submodule changes, but you can in git 2.3.
Thus there's a slight difference in what happens given the code we have
now.

In git 1.8, we would check to see if you had only staged submodule
changes (by checking if no stash was created), and would not hard
reset in that case. Since there was no hard reset, no empty submodule
directory would be created, and all is well (though we don't have any
stash to restore anyway).

In git 2.3, a stash would be created so we would hard reset. This would
create an empty submodule directory which we would then have to
explicitly remove in order to restore the stash we just created.

The test I've added passes for both versions of git, even though it's
technically only testing git 2.3. We'll have to come up with a way of
running overcommit tests against multiple versions of git in Travis so
we know we're not writing version-specific implementations.

Coverage Stats

1699 of 1905 relevant lines covered (89.19%)

24.23 hits per line

sds / overcommit / 744 / 3
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 744.3 (2.1)

sds / overcommit / 744 / 3 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 744.3 (2.1)

sds / overcommit / 744 / 3
91%
master: 91%

README BADGES
x