5
73%
master: 73%

Ran 21 Sep 2019 07:54AM UTC

Files 30

Run time 1s

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 60.653%. First build

Job # GO111MODULE=on

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

1022 of 1685 relevant lines covered (60.65%)

4735.04 hits per line

openzipkin / zipkin-go / 538 / 5
73%
master: 73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 538.5 (GO111MODULE=on)

openzipkin / zipkin-go / 538 / 5 73% master: 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 538.5 (GO111MODULE=on)

openzipkin / zipkin-go / 538 / 5
73%
master: 73%

README BADGES
x