wikimedia / parsoid / 3022 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/6187b179a">Fix inefficiencies looking up id attributes in storeDataAttribs

* This is a second attempt to address PHP DOM issues with getElementById
  and Zest&#39;s ineffiencies in looking up ids on the DOM via XPath.

* This fixes performance on the tagged task.

* In the first attempt of this patch, I had used a querySelectorAll([&#39;id])
  but a manual visitDOM turned out to be much faster than that even
  though the querySelectorAll did fix the n^2 issue.

* Also condition the check in visitAndStoreDataAttribs on whether
  we need to storeInPageBundle since it turns out html2wt had slowed
  down 2x since 6fa28acd which unconditionally used the querySelector
  hack in visitAndStoreDataAttribs.

* Flamegraph confirms the fix.

Bug: T232180
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/bb80bd81c">bb80bd81c</a>

Run Details

9641 of 12141 branches covered (79.41%)

15073 of 17775 relevant lines covered (84.8%)

31762.41 hits per line