aiidateam / aiida-core / 7029 / 7

70%

develop: 70%

push

travis-ci

<a href="https://github.com/aiidateam/aiida-core/commit/<a class=hub.com/aiidateam/aiida-core/commit/<a class="double-link" href="https://git"><a class=hub.com/aiidateam/aiida-core/commit/<a class="double-link" href="https://git"><a class=hub.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96">6299cf6c9<a href="https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96">&lt;a href=&quot;https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;remove manipulations of sys.path (#3305)

python allows to modify the search path for modules programmatically via the `sys.path` variable (`sys.path` is initialized from the `PYTHONPATH` environment variable).
Doing so, however, can easily have unintended consequences (one of them surfaced in #3293) - in particular, when new paths are inserted at the *beginning* of `sys.path`.

AiiDA was manipulating `sys.path` in a number of places:

1. https://github.com/aiidateam/aiida-core/blob/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/aiidateam/aiida-core/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&quot;https://github.com/aiidateam/aiida-core/commit/a500d2b2801efa393ce6f567dc9893a62696b8f1&quot;&gt;a500d2b28&lt;/a&gt;&quot;&gt;a500d2b28&lt;/a&gt;&lt;a href=&quot;https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96&quot;&gt;/aiida/cmdline/commands/cmd_run.py#L113

1. https://github.com/aiidateam/aiida-core/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/aiidateam/aiida-core/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/aiidateam/aiida-core/commit/d750d513f7adf5126d43a230c9fb378de02f0772&quot;&gt;d750d513f</a>">d750d513f</a><a href="https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96">/aiida/sphinxext/tests/workchain_source/conf.py#L32

1. https://github.com/aiidateam/aiida-core/blob/</a><a class="double-link" href="https://github.com/aiidateam/aiida-core/commit/<a class="double-link" href="https://git"><a class=hub.com/aiidateam/aiida-core/commit/<a class=hub.com/aiidateam/aiida-core/commit/cc94a1e0127cd9cab0a4049e69a9fa31cb82941c">cc94a1e01">cc94a1e01</a><a href="https://github.com/aiidateam/aiida-core/commit/6299cf6c961f27c64c0a146130f52adafcba9d96">/utils/validate_consistency.py#L190

1. https://github.com/aiidateam/aiida-core/blob/cc94a1e0127cd9cab0a4049e69a9fa31cb82941c/aiida/common/files.py#L194

1. https://github.com/aiidateam/aiida-core/blob/</a><a class="double-link" href="https://github.com/aiidateam/aiida-core/commit/91b205bcd">91b205bcd</a><a href="https://github.com/aiidateam/aiida-core... (continued)

26352 of 89268 relevant lines covered (29.52%)

0.3 hits per line