1
73%
master: 73%

Ran 15 Sep 2019 03:47PM UTC

Files 39

Run time 2s

Badge

Embed ▾

Committed 15 Sep 2019 03:41PM UTC coverage: 75.429% (-6.0%) from 81.457%

Job # 534.1

Build Type

push

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

1845 of 2446 relevant lines covered (75.43%)

3867.26 hits per line

openzipkin / zipkin-go / 534 / 1
73%
master: 73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 534.1

openzipkin / zipkin-go / 534 / 1 73% master: 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 534.1

openzipkin / zipkin-go / 534 / 1
73%
master: 73%

README BADGES
x