1
92%
master: 92%

Ran 12 Sep 2019 08:02PM UTC

Files 99

Run time 4s

Badge

Embed ▾

Committed 12 Sep 2019 07:59PM UTC coverage: 90.904% (+0.04%) from 90.867%

Job # 566.1

Build Type

push

travis-ci

Committed by

erosb

Commit Message

omitting stacktraces for internal exceptions

The purpose of this change is to avoid stacktrace generation for most `ValidationException` instances, since it can
come with significant performance improvements in some usecases, see #318 .

An `InternalValidationException` is introduced which is a subclass of `ValidationException` but it omits the stacktrace
generation by overriding `fillInStackTrace()` to be no-op. This is now thrown everywhere internally. At the end of the
validation process the `DefaultValidator` catches the possibly thrown `InternalValidationException` and copies it into a
`ValidationInstance` and throws it, so from the caller point of view an exception with a proper stacktrace is thrown. This
"public" `ValidationException` is necessary to avoid any potential BC breaks.

Tests updated. A good number of unittests and all of the integration tests verify that only root exceptions (and no causing
exceptions) have non-empty stacktraces. There is some code duplication between the unit and integ test codebase, this is
to be cleaned up a bit in the future (needs a separate testutil module which can be depended on by both `core` and
`tests/vanilla`).

Run Details

2978 of 3276 relevant lines covered (90.9%)

0.91 hits per line

everit-org / json-schema / 566 / 1
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 566.1

everit-org / json-schema / 566 / 1 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 566.1

everit-org / json-schema / 566 / 1
92%
master: 92%

README BADGES
x