4
52%
master: 54%

Ran 06 Sep 2019 01:49AM CUT

Files 12

Run time 1s

Badge

Embed ▾

Committed 06 Sep 2019 01:40AM CUT coverage: 51.301% (+0.8%) from 50.489%

Job # 988.4

Build Type

Pull #744

travis-ci

Committed by

web-flow

Commit Message

Fix context cancellation racy handling

[why]
Context cancellation goroutine is not in sync with Next() method lifetime.
It leads to sql.ErrNoRows instead of context.Canceled often (easy to reproduce).
It leads to interruption of next query executed on same connection (harder to reproduce).

[how]
Do query in goroutine, wait when interruption done.

[testing]
Add unit test that reproduces error cases.

Pull Request Pull Request #744: Fix context cancellation racy handling

Run Details

986 of 1922 relevant lines covered (51.3%)

92563.25 hits per line

Source Files on job 988.4

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	sqlite3_load_extension.go	71 + 69	37 + 36	0	37 + 36	0.0
0.0	sqlite3_type.go	58 - 41	24 - 24	0 - 47	24 + 23	0.0 - 1.0
0.0	convert.go	300 + 279	235 + 235	0	235 + 235	0.0
0.0	sqlite3_context.go	104 - 126	39 - 87	0 - 36	39 - 51	0.0 - 1.0
0.0	sqlite3_opt_preupdate_omit.go	22 - 114	3 - 69	0 - 70	3 + 1	0.0 - 1.0
10.0	sqlite3_opt_userauth_omit.go	153 + 92	40 - 1	4 - 37	36 + 36	10092.0 + 10091
60.18	sqlite3.go	2088 + 1760	1140 + 945	686 + 628	454 + 317	247706.0 + 247705
62.31	callback.go	399 + 335	268 + 221	167 + 167	101 + 54	11303.0 + 11303
90.48	backup.go	86 + 47	42 + 21	38 + 38	4 - 17	3.0 + 3
91.67	sqlite3_go18.go	71 + 69	36 + 36	33 + 33	3 + 3	183381.0 + 183381

Showing 1 to 10 of 12 entries

mattn / go-sqlite3 / 988 / 4
52%
master: 54%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 988.4

mattn / go-sqlite3 / 988 / 4 52% master: 54%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 988.4

mattn / go-sqlite3 / 988 / 4
52%
master: 54%

README BADGES
x