wikimedia / parsoid / 2991 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/498ee5aa5">Fix comment fragment regexp to avoid PREG_JIT_STACKLIMIT_ERROR

* Anomie suggested this fix to make the regexp more efficient.

* I cannot backport this to JS since it doesn&#39;t support this
  &quot;Once-only subpatterns&quot; feature.
  See https://www.php.net/manual/en/regexp.reference.onlyonce.php

  Without this feature, when &quot;&lt;!--[\s\S]*?--&gt;&quot; is embedded in other
  regexps, it could match across multiple comments when it backtracks.

  Specifically, the &quot;Comment spacing&quot; parser test fails without this
  once-only subpattern protection. This is because of its usage in
  the html2wt PreHandler.

* This fixes a crasher seen in round trip testing.
  Tested on enwiki:Norio Wakamoto.

Bug: T231651
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/db2676533">db2676533</a>

Run Details

9640 of 12141 branches covered (79.4%)

15068 of 17771 relevant lines covered (84.79%)

31837.0 hits per line