Robbepop / string-interner / 701 / 2

97%

master: 33%

push

travis-ci

<a href="https://github.com/Robbepop/string-interner/commit/<a class=hub.com/Robbepop/string-interner/commit/8d24e66d5f138e158105a5f28f1b41fe478665c4">8d24e66d5<a href="https://github.com/Robbepop/string-interner/commit/8d24e66d5f138e158105a5f28f1b41fe478665c4">&quot;&gt;Backport clone bugfix on top of 0.6.3 (#14)

* backport use-after-free bugfix in `StringInterner::clone()` onto 0.6.3

Backported by Pat Hickey &amp;lt;phickey@fastly.com&amp;gt;

In master branch and 0.7.1 release as </a><a class="double-link" href="https://github.com/Robbepop/string-interner/commit/<a class="double-link" href="https://github.com/Robbepop/string-interner/commit/d91dac0cfe42512526879cdfaac0b81beff54089">d91dac0cf</a>">d91dac0cf</a><a href="https://github.com/Robbepop/string-interner/commit/8d24e66d5f138e158105a5f28f1b41fe478665c4">

Original PR: https://github.com/Robbepop/string-interner/pull/10

From original commit message:

&gt; * Add a test which may fail for use after free bug #9
&gt;
&gt; * Implement `Clone` manually for `StringInterner`
&gt;
&gt; New `clone()` implementation recreates `HashMap` to update key
&gt; `InternalStrRef`s with pointer to newly cloned strings.

&gt; `#[derive(Clone)]` requires `S: Clone` automatically, and the new
&gt; `Clone` implementation does not require it explicitly.
&gt; However, `S: Symbol` trait bound indirectly requires `S: Clone`, so
&gt; the restriction for `S` is actually not changed.

&gt; Fixes #9.

* Backport: Add a test to ensure that interners have no dangling pointers

From https://github.com/Robbepop/string-interner/pull/12/commits/eb54ae076">eb54ae076</a>

270 of 286 relevant lines covered (94.41%)

1.59 hits per line