5
85%
master: 85%

Ran 14 Aug 2019 07:09PM UTC

Files 7

Run time 2s

Badge

Embed ▾

Committed 14 Aug 2019 07:07PM UTC coverage: 82.552% (-2.0%) from 84.586%

Job # LANG=C

Build Type

Pull #155

travis-ci

Committed by

web-flow

Commit Message

QueryBuilder.py: Use native data structures for internal representation

The [PuppetDB documentation][1] says that queries are JSON arrays, so
this commit updates all of the QueryBuilder classes to use lists/dicts
for the internal representation and defers the JSON serialization until
the `str()` call. This avoids having to manually quote things or do
string manipulation. `obj.json_data()` will return the native data
structure and `str(obj)` will return the serialized JSON.

Most of the changes to the tests are just fixing whitespace, but there
are a few places where duplicated quotes and backslash escaping were
fixed.

[1]: https://puppet.com/docs/puppetdb/5.1/api/query/v4/facts.html#url-parameters

Fixes: #140

Signed-off-by: Andrew Gunnerson <andrew.gunnerson@us.ibm.com>

Pull Request Pull Request #155: QueryBuilder.py: Use native data structures for internal representation

Run Details

634 of 768 relevant lines covered (82.55%)

0.83 hits per line

voxpupuli / pypuppetdb / 376 / 5
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 376.5 (LANG=C)

voxpupuli / pypuppetdb / 376 / 5 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 376.5 (LANG=C)

voxpupuli / pypuppetdb / 376 / 5
85%
master: 85%

README BADGES
x