kubeflow / pipelines / 3922 / 1

0%

master: 0%

push

travis-ci-com

Backend - Docker build should fail on sample compilation failures (#1760)

Problem: Docker implicitly prepends "sh -c " to the RUN commands (no "-e"). Without "-e", the exit code of the shell script is the exit code of the last executed command. So the csample compilation script will only fail if the last sample failed the compilation.

Fix: Explicitly adding "set -e" to the command fixes the issue.

Fixes https://github.com/kubeflow/pipelines/issues/1735

1587 of 1791 branches covered (88.61%)

Branch coverage included in aggregate %.

2697 of 2848 relevant lines covered (94.7%)

60.95 hits per line