1
92%
master: 92%

Ran 30 Mar 2015 11:59PM UTC

Files 9

Run time 1s

Badge

Embed ▾

Committed 30 Mar 2015 11:57PM UTC coverage: 86.61% (+0.5%) from 86.08%

Job # 297.1

Build Type

push

travis-ci

Committed by

gwicke

Commit Message

Consistently use previous renders for html2wt conversion

Previously we didn't properly handle template re-renders in the middle of an
edit. The HTML and data-parsoid passed to Parsoid would always use the latest
render, which was potentially out of sync with the original render. This could
lead to dirty diffs.

This patch addresses this by:

- accepting an 'If-Match' header in transform methods, which is expected to
  contain the Etag (timeuuid) returned by the original HTML / data-parsoid
- Also, as a convenient way to support this quickly in current VE, injecting
  the timeuuid in a meta tag in the head section of the saved HTML & plucking
  that back out if no If-Match header was provided.

Bug: https://phabricator.wikimedia.org/T94422

Coverage Stats

815 of 941 relevant lines covered (86.61%)

41.6 hits per line

gwicke / restbase / 297 / 1
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 297.1

gwicke / restbase / 297 / 1 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 297.1

gwicke / restbase / 297 / 1
92%
master: 92%

README BADGES
x