1
99%
master: 97%

Ran 02 Aug 2019 07:22AM UTC

Files 5

Run time 0s

Badge

Embed ▾

Committed 02 Aug 2019 07:08AM UTC coverage: 89.362% (-0.2%) from 89.547%

Job # 1493.1

Build Type

Pull #3

travis-ci-com

Committed by

web-flow

Commit Message

DS-2570: remove original.subset and just use subset

I'm not sure why original.subset was used when missing = "Use partial
data" and a filter is provided (line 192 of the original code). The only
time original.subset differs from subset is when one of the weights is
zero or all values for a case are missing. When they do differ, a crash
occurs as we end up mixing vectors of different lengths, I have added
tests for these two cases, which used to fail but now pass with my
changes. Please also check the line "if (!(has.subset & (partial |
weighted)))
result$cluster[subset] <- model$cluster # This will often do nothing."
as the condition seems strange to me.

Pull Request Pull Request #3: DS-2570: remove original.subset and just use subset

Run Details

252 of 282 relevant lines covered (89.36%)

693.0 hits per line

Displayr / flipCluster / 1493 / 1
99%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1493.1

Displayr / flipCluster / 1493 / 1 99% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1493.1

Displayr / flipCluster / 1493 / 1
99%
master: 97%

README BADGES
x