sonata-project / SonataMediaBundle / 3804 / 1

51%

3.x: 51%

cron

travis-ci

<a href="https://github.com/sonata-project/SonataMediaBundle/commit/<a class=hub.com/sonata-project/SonataMediaBundle/commit/f25bc3f465d89e1a0e75d6f9b277db64e0b4b014">f25bc3f46<a href="https://github.com/sonata-project/SonataMediaBundle/commit/f25bc3f465d89e1a0e75d6f9b277db64e0b4b014">&quot;&gt;Fixed deletion of images with id greater than 1000 (#1592)

* Fixed deletion of images with id greater than 1000

Inside the $this-&amp;gt;getReferenceImage() method, the id of the $media object is used, but at the time of the postRemove event, the $media object is detached from an EntityManager and its id is null. During the postRemove event, the $media-&amp;gt;getId() method returns null, and the $this-&amp;gt;getReferenceImage() method returns the wrong path and the file remains in the file system as garbage. My changes fix this.

* Add testPostRemove().

Test for &amp;quot;Fix deletion of images with id greater than 1000&amp;quot;.

* Update testPostRemove().

* The visibility of the property &amp;quot;clones&amp;quot; is changed to private.

* Adapted test &amp;quot;testPostRemove&amp;quot; to check the data in the private property &amp;quot;clones&amp;quot; instead of the protected.

* Update src/Provider/BaseProvider.php

Co-Authored-By: Javier Spagnoletti &amp;lt;phansys@gmail.com&amp;gt;

* Update src/Provider/BaseProvider.php

Co-Authored-By: Javier Spagnoletti &amp;lt;phansys@gmail.com&amp;gt;

* Update tests/Provider/BaseProviderTest.php

Co-Authored-By: Javier Spagnoletti &amp;lt;phansys@gmail.com&amp;gt;

* Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me.

* Revert &amp;quot;Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me.&quot;

This reverts commit </a><a class="double-link" href="https://github.com/sonata-project/SonataMediaBundle/commit/<a class="double-link" href="https://github.com/sonata-project/SonataMediaBundle/commit/bab31c8e3b3d662651634a4d90ccdd456adddde1">bab31c8e3</a>">bab31c8e3</a><a href="https://github.com/sonata-project/SonataMediaBundle/commit/f25bc3f465d89e1a0e75d6f9b277db64e0b4b014">.

* Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me.

* Remove un... (continued)

2181 of 4241 relevant lines covered (51.43%)

4.19 hits per line