tf / pageflow / 2220 / 2
99%
master: 99%

LAST BUILD BRANCH: actions
DEFAULT BRANCH: master
Ran
Files 434
Run time 35s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 99.284%. Remained the same
2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true

push

travis-ci

tf 
Support CDN that redirects to HTTPS

Previously, when using protocol relative URLs for paperclip and
zencoder attachments, HTTP was used as default protocol in social
share meta tag image URLs and when downloading thumbnails and posters
generated by Zencoder.

Also HTTPS URLs were actively rewritten to HTTP due to some cargo
culted workaround for a problem where Facebook had problems with HTTPS
urls.

In both cases a redirect to HTTPS served by the CDN caused problems:

* Facebook does not appear to follow redirects and instead complains
  about invalid content type.

* `open-uri` which is used by Paperclip to perform the image download
  also does not follow redirects. Video Files stay in `encoding` state
  forever since `PollZencoderJob` assumes thumbnails are not there
  yet.

It should be safe to assume that the CDN supports HTTPS if protocol
relative URLs were configured in the first place. We therefore use
HTTPS as default protocol to solve the issue.

It will be a good idea for the host application to use HTTPS protocols
instead of protocol relative URLs to prevent extra redirects, but
still this change ensures Pageflow at least works in this case.

There is a third place that supplies HTTP as default protocol: URLs in
SMIL files used to have Akamai generate HLS files (see
`ZencoderVideoOutputDefinition`). Since the known Akamai setups using
this option do not redirect to HTTPS, the default protocol was left
unchanged to prevent regressions.

REDMINE-16967

16084 of 16200 relevant lines covered (99.28%)

30.39 hits per line

Source Files on job 2220.2 (2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)