1
99%
master: 99%

Ran 23 Jul 2019 04:53PM UTC

Files 434

Run time 52s

Badge

Embed ▾

Committed 23 Jul 2019 04:40PM UTC coverage: 99.277%. Remained the same

Job # 2.3.1, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true

Build Type

push

travis-ci

Committed by

Commit Message

Support CDN that redirects to HTTPS

Previously, when using protocol relative URLs for paperclip and
zencoder attachments, HTTP was used as default protocol in social
share meta tag image URLs and when downloading thumbnails and posters
generated by Zencoder.

Also HTTPS URLs were actively rewritten to HTTP due to some cargo
culted workaround for a problem where Facebook had problems with HTTPS
urls.

In both cases a redirect to HTTPS served by the CDN caused problems:

* Facebook does not appear to follow redirects and instead complains
  about invalid content type.

* `open-uri` which is used by Paperclip to perform the image download
  also does not follow redirects. Video Files stay in `encoding` state
  forever since `PollZencoderJob` assumes thumbnails are not there
  yet.

It should be safe to assume that the CDN supports HTTPS if protocol
relative URLs were configured in the first place. We therefore use
HTTPS as default protocol to solve the issue.

There is a third place that supplies HTTP as default protocol: URLs in
SMIL files used to have Akamai generate HLS files (see
`ZencoderVideoOutputDefinition`). Since the known Akamai setups using
this option do not redirect to HTTPS, the default protocol was left
unchanged to prevent regressions.

REDMINE-16967

Coverage Stats

16066 of 16183 relevant lines covered (99.28%)

30.45 hits per line

tf / pageflow / 2218 / 1
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2218.1 (2.3.1, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)

tf / pageflow / 2218 / 1 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2218.1 (2.3.1, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)

tf / pageflow / 2218 / 1
99%
master: 99%

README BADGES
x