wikimedia / parsoid / 2837 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/<a class=hub.com/wikimedia/parsoid/commit/031b6d40c9a76f0c13d15f59cb6fb6539749dc61">031b6d40c<a href="https://github.com/wikimedia/parsoid/commit/031b6d40c9a76f0c13d15f59cb6fb6539749dc61">&quot;&gt;Fix dsr test to check start against null, not &amp;#39;truthy&amp;#39;

This code is triggered on wikitext with badly nested &amp;lt;a&amp;gt; tags, such
as [http://example.org [[Foo]]]

The test *should* be that the start dsr is non-null; &amp;#39;0&amp;#39; is a legit
value.

However, this fix is mostly theoretical, as I can&amp;#39;t figure out how to
write a test case such that dsr start is actually 0 here: you need
opening brackets in wikitext to start the link, and those will always
bump the dsr up by at least one.  Still, I&amp;#39;m pretty confident this
patch is the *correct* way to do this test.

Follow up to a comment on I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/<a class="double-link" href="https://github.com/wikimedia/parsoid/commit/7795cedf14e6ff56a31eeaba0a32c3c5c3166f08">7795cedf1</a>">7795cedf1</a><a href="https://github.com/wikimedia/parsoid/commit/031b6d40c9a76f0c13d15f59cb6fb6539749dc61">.

Change-Id: I059a17412">059a17412</a>

Run Details

9616 of 12116 branches covered (79.37%)

15021 of 17755 relevant lines covered (84.6%)

29572.69 hits per line